Save large icons to a new LARGE_ICON type

components/favicon/core/large_icon_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/large_icon_service.h"
 
 #include "components/favicon/core/favicon_service.h"
 #include "components/favicon_base/fallback_icon_style.h"
 #include "components/favicon_base/favicon_types.h"
 
 namespace favicon {
 
 LargeIconService::LargeIconService(FaviconService* favicon_service)
     : favicon_service_(favicon_service) {
+  large_icon_types_.push_back(favicon_base::IconType::LARGE_ICON);

[huangs, 2015/05/04 05:17:30]

NIT: Move this after TOUCH_PRECOMPOSED_ICON for consistency, or comment on why
this comes first.

[Roger McFarlane (Chromium), 2015/05/04 18:48:15]

Done.

   large_icon_types_.push_back(favicon_base::IconType::FAVICON);
   large_icon_types_.push_back(favicon_base::IconType::TOUCH_ICON);
   large_icon_types_.push_back(favicon_base::IconType::TOUCH_PRECOMPOSED_ICON);
 }
 
 LargeIconService::~LargeIconService() {
 }
 
 base::CancelableTaskTracker::TaskId
     LargeIconService::GetLargeIconOrFallbackStyle(
@@ skipping 42 matching lines @@
   }
 
   // The bitmap is square and at least as large as the requested one, return
   // it.
   // TODO(beaudoin): Resize the icon if it's too large. Alternatively, return
   // it and let the HTML resize it.
   callback.Run(favicon_base::LargeIconResult(bitmap_result));
 }
 
 }  // namespace favicon