Issue 11190062: Merge 162269 - Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11190062: Merge 162269 - Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in… (Closed)

Created:
8 years, 2 months ago by ananta

Modified:
8 years, 2 months ago

Reviewers:
ananta

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Merge 162269 - Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver. Fix is to ignore the navigation request in this case. I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122 BUG=155281, 135122 R=cpu Review URL: https://codereview.chromium.org/11193007 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162799

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	win8/metro_driver/chrome_url_launch_handler.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)