Move NTDDI_VERSION define to common.gypi.

Move NTDDI_VERSION define to common.gypi.

This centralizes this definition and removes it from the various places it is currently replicated. This also allows external projects that rely on Chromium base to compile successfully, as otherwise this (required) definition is missing.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163299

[chrisha, 2012-10-18 21:09:00]

PTAL.

[chrisha, 2012-10-19 17:49:31]

robertsheild brought up the point that this may very well break VS2008 builds,
but I thought since the Win8 stuff was rolled in we no longer supported VS2008
builds anyways? The common.gypi could always be wrapped in an MSVS_VERSION=2010
condition. Thoughts?

[robertshield, 2012-10-19 18:00:30]

On 2012/10/19 17:49:31, chrisha wrote:
> robertsheild brought up the point that this may very well break VS2008 builds,
> but I thought since the Win8 stuff was rolled in we no longer supported VS2008
> builds anyways?

FWIW, the reason for dropping VS2008 is that we don't want to support old tool
chains that we don't ship with. Too much work, no real upside.

 The common.gypi could always be wrapped in an MSVS_VERSION=2010
> condition. Thoughts?

If it builds on 2008 with this change, don't bother. If it doesn't, probably
still don't bother, since someone will eventually use something from the Win8
SDK that is defined under this macro and break 2008 without knowing about it.

I was mainly curious as to whether it would still build, since if it doesn't I
would expect angry mail from people who use VS2008 and ignore deprecation
announcements. This may be acceptable, or we could figure out another way of
doing this.

[cpu_(ooo_6.6-7.5), 2012-10-19 23:01:10]

On 2012/10/19 17:49:31, chrisha wrote:
> robertsheild brought up the point that this may very well break VS2008 builds,
> but I thought since the Win8 stuff was rolled in we no longer supported VS2008
> builds anyways? The common.gypi could always be wrapped in an
MSVS_VERSION=2010
> condition. Thoughts?

VS2008 builds have been broken since tuesday. The last v2008 has been removed so
farewell to that toolchain.

Checks of (MSVS_VERSION=2010) are bad. We are trying to get vs2012 off the
ground and that makes our life harder.

[robertshield, 2012-10-20 01:19:45]

On Fri, Oct 19, 2012 at 7:01 PM, <cpu@chromium.org> wrote:

> On 2012/10/19 17:49:31, chrisha wrote:
>
>> robertsheild brought up the point that this may very well break VS2008
>> builds,
>> but I thought since the Win8 stuff was rolled in we no longer supported
>> VS2008
>> builds anyways? The common.gypi could always be wrapped in an
>>
> MSVS_VERSION=2010
>
>> condition. Thoughts?
>>
>
> VS2008 builds have been broken since tuesday. The last v2008 has been
> removed so
> farewell to that toolchain.
>

Huh, that was faster than I expected :-) Ok, I retract my question, LGTM


>
> Checks of (MSVS_VERSION=2010) are bad. We are trying to get vs2012 off the
> ground and that makes our life harder.
>
>
http://codereview.chromium.**org/11190060/<http://codereview.chromium.org/111...
>

[chrisha, 2012-10-22 13:32:24]

Wohooo! No more VS2008!

Thanks, committing.

[commit-bot: I haz the power, 2012-10-22 13:32:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/11190060/1

[commit-bot: I haz the power, 2012-10-22 16:23:14]

Change committed as 163299