[cros] Update wallpaper when displaying Gaia frame.

[cros] Update wallpaper when displaying Gaia frame.

*) When adding new user, show the default wallpaper.
*) When clicking on a user, who requires online auth, load their wallpaper.
*) When cancelling online auth, revert to the last active user's wallpaper.

BUG=153700, 139074
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162454

[Ivan Korotkov, 2012-10-17 14:24:28]

+Biao

[bshe, 2012-10-17 14:47:29]

On 2012/10/17 14:24:28, Ivan Korotkov wrote:
> +Biao

wallpaper_manager lgtm

[Nikita (slow), 2012-10-17 14:51:03]

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/login/user_pod_row.js (right):

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/user_pod_row.js:430: lastFocusedPod_:
undefined,
You should probably clear that if user is deleted?

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/user_pod_row.js:738:
this.loadLastWallpaper_();
I suspect that reset might be called multiple times for instance when you enter
password incorrectly.

I know that we would not load same wallpaper if it is already loaded (Biao?) but
we should not do this call here in the first place.

Should it be called when we cancel GAIA sign in?

[bshe, 2012-10-17 15:13:50]

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/login/user_pod_row.js (right):

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/user_pod_row.js:738:
this.loadLastWallpaper_();
We will not reload the same built in wallpaper. But for custom wallpaper or
online wallpaper, I believe we do.

On 2012/10/17 14:51:03, Nikita Kostylev wrote:
> I suspect that reset might be called multiple times for instance when you
enter
> password incorrectly.
> 
> I know that we would not load same wallpaper if it is already loaded (Biao?)
but
> we should not do this call here in the first place.
> 
> Should it be called when we cancel GAIA sign in?

[Ivan Korotkov, 2012-10-17 15:34:10]

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/login/user_pod_row.js (right):

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/user_pod_row.js:430: lastFocusedPod_:
undefined,
On 2012/10/17 14:51:03, Nikita Kostylev wrote:
> You should probably clear that if user is deleted?

Done.

http://codereview.chromium.org/11190022/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/user_pod_row.js:738:
this.loadLastWallpaper_();
On 2012/10/17 15:13:50, bshe wrote:
> We will not reload the same built in wallpaper. But for custom wallpaper or
> online wallpaper, I believe we do.
> 
> On 2012/10/17 14:51:03, Nikita Kostylev wrote:
> > I suspect that reset might be called multiple times for instance when you
> enter
> > password incorrectly.
> > 
> > I know that we would not load same wallpaper if it is already loaded (Biao?)
> but
> > we should not do this call here in the first place.
> > 
> > Should it be called when we cancel GAIA sign in?
> 

Fixed, now we only call loadLastWallpaper in response to "Cancel" click

[Nikita (slow), 2012-10-17 15:39:30]

lgtm

[commit-bot: I haz the power, 2012-10-17 15:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11190022/7001

[commit-bot: I haz the power, 2012-10-17 17:54:48]

Change committed as 162454