Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 11189112: Reland JSON.stringify reimplementation. (Closed)

Created:
8 years, 2 months ago by Yang
Modified:
8 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Reland JSON.stringify reimplementation. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12790

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : makev8 ia32.release.check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+728 lines, -23 lines) Patch
M src/json.js View 1 chunk +3 lines, -1 line 0 comments Download
A src/json-stringifier.h View 1 2 1 chunk +657 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M test/mjsunit/json.js View 1 chunk +36 lines, -0 lines 0 comments Download
A + test/mjsunit/json-recursive.js View 1 1 chunk +11 lines, -16 lines 0 comments Download
A + test/mjsunit/regress/regress-json-stringify-gc.js View 1 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. Interesting changes are the deltas 1 and 2 to json-stringifier.h
8 years, 2 months ago (2012-10-22 13:22:15 UTC) #1
Toon Verwaest
8 years, 2 months ago (2012-10-22 13:45:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698