Issue 11189088: Add controlled setting indicator for default search engine configuration

Issue 11189088: Add controlled setting indicator for default search engine configuration (Closed)

Created:
8 years, 2 months ago by bartfab (slow)

Modified:
8 years, 2 months ago

Reviewers:
Joao da Silva, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add controlled setting indicator for default search engine configuration This CL adds controlled setting indicators that show when the default search engine configuration is managed by policy. BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163017

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment addressed. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager_engine_list.js	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/policy/policy_test_cases.json	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

Hi James, could you take a look at the UI side of this CL? Hi ...

8 years, 2 months ago (2012-10-19 12:09:55 UTC) #1

Joao da Silva

policy/ lgtm https://chromiumcodereview.appspot.com/11189088/diff/1/chrome/browser/ui/webui/options/search_engine_manager_handler.cc File chrome/browser/ui/webui/options/search_engine_manager_handler.cc (right): https://chromiumcodereview.appspot.com/11189088/diff/1/chrome/browser/ui/webui/options/search_engine_manager_handler.cc#newcode205 chrome/browser/ui/webui/options/search_engine_manager_handler.cc:205: dict->SetString("controlledBy", "policy"); Isn't this the same signal ...

8 years, 2 months ago (2012-10-19 12:21:21 UTC) #2

bartfab (slow)

https://chromiumcodereview.appspot.com/11189088/diff/1/chrome/browser/ui/webui/options/search_engine_manager_handler.cc File chrome/browser/ui/webui/options/search_engine_manager_handler.cc (right): https://chromiumcodereview.appspot.com/11189088/diff/1/chrome/browser/ui/webui/options/search_engine_manager_handler.cc#newcode205 chrome/browser/ui/webui/options/search_engine_manager_handler.cc:205: dict->SetString("controlledBy", "policy"); Good catch. Done.

8 years, 2 months ago (2012-10-19 12:40:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11189088/5001

8 years, 2 months ago (2012-10-19 15:41:46 UTC) #5

Change committed as 163017

Expand Messages | Collapse Messages