Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3043)

Unified Diff: chrome/browser/android/crash_dump_manager.h

Issue 11189068: Changing minidump process generation to be in-process on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced again. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_main_delegate.cc ('k') | chrome/browser/android/crash_dump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/crash_dump_manager.h
diff --git a/chrome/browser/android/crash_dump_manager.h b/chrome/browser/android/crash_dump_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..2f85c5745acea4666b4631f6603142ac4e98c4e0
--- /dev/null
+++ b/chrome/browser/android/crash_dump_manager.h
@@ -0,0 +1,66 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+#define CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
+
+#include <map>
+
+#include "base/file_path.h"
+#include "base/platform_file.h"
+#include "base/synchronization/lock.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+namespace content {
+class RenderProcessHost;
+}
+
+// This class manages the crash minidumps.
+// On Android, because of process isolation, each renderer process runs with a
+// different UID. As a result, we cannot generate the minidumps in the browser
+// (as the browser process does not have access to some system files for the
+// crashed process). So the minidump is generated in the renderer process.
+// Since the isolated process cannot open files, we provide it on creation with
+// a file descriptor where to write the minidump in the event of a crash.
+// This class creates these file descriptors and associates them with render
+// processes and take the appropriate action when the render process terminates.
+class CrashDumpManager : public content::NotificationObserver {
+ public:
+ // Should be created on the UI thread.
+ CrashDumpManager();
+ virtual ~CrashDumpManager();
+
+ // Returns a file descriptor that should be used to generate a minidump for
+ // the process |child_process_id|.
+ int CreateMinidumpFile(int child_process_id);
+
+ private:
+ struct MinidumpInfo {
+ MinidumpInfo() : file(base::kInvalidPlatformFileValue) {}
+ base::PlatformFile file;
+ FilePath path;
+ int pid;
+ };
+
+ typedef std::map<int, MinidumpInfo> ChildProcessIDToMinidumpInfo;
+
+ static void ProcessMinidump(const MinidumpInfo& minidump);
+
+ // NotificationObserver implementation:
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
+ content::NotificationRegistrar notification_registrar_;
+
+ // This map should only be accessed with its lock aquired as it is accessed
+ // from the PROCESS_LAUNCHER and UI threads.
+ base::Lock child_process_id_to_minidump_info_lock_;
+ ChildProcessIDToMinidumpInfo child_process_id_to_minidump_info_;
+
+ DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
+};
+
+#endif // CHROME_BROWSER_ANDROID_CRASH_DUMP_MANAGER_H_
« no previous file with comments | « chrome/app/chrome_main_delegate.cc ('k') | chrome/browser/android/crash_dump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698