Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: chrome/app/chrome_main_delegate.cc

Issue 11189068: Changing minidump process generation to be in-process on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced again. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/breakpad_linux.cc ('k') | chrome/browser/android/crash_dump_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_main_delegate.h" 5 #include "chrome/app/chrome_main_delegate.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 // Update the process name (need resources to get the strings, so 636 // Update the process name (need resources to get the strings, so
637 // only do this when ResourcesBundle has been initialized). 637 // only do this when ResourcesBundle has been initialized).
638 SetMacProcessName(command_line); 638 SetMacProcessName(command_line);
639 #endif // defined(OS_MACOSX) 639 #endif // defined(OS_MACOSX)
640 } 640 }
641 641
642 #if defined(USE_LINUX_BREAKPAD) 642 #if defined(USE_LINUX_BREAKPAD)
643 // Needs to be called after we have chrome::DIR_USER_DATA. BrowserMain 643 // Needs to be called after we have chrome::DIR_USER_DATA. BrowserMain
644 // sets this up for the browser process in a different manner. Zygotes 644 // sets this up for the browser process in a different manner. Zygotes
645 // need to call InitCrashReporter() in RunZygote(). 645 // need to call InitCrashReporter() in RunZygote().
646 if (!process_type.empty() && process_type != switches::kZygoteProcess) 646 if (!process_type.empty() && process_type != switches::kZygoteProcess) {
647 #if defined(OS_ANDROID)
648 // On Android we need to provide a FD to the file where the minidump is
649 // generated as the renderer and browser run with different UIDs
650 // (preventing the browser from inspecting the renderer process).
651 int minidump_fd = base::GlobalDescriptors::GetInstance()->
652 MaybeGet(kAndroidMinidumpDescriptor);
653 if (minidump_fd == base::kInvalidPlatformFileValue) {
654 NOTREACHED() << "Could not find minidump FD, crash reporting disabled.";
655 } else {
656 InitNonBrowserCrashReporterForAndroid(minidump_fd);
657 }
658 #else
647 InitCrashReporter(); 659 InitCrashReporter();
648 #endif 660 #endif
661 }
662 #endif
649 663
650 #if defined(OS_CHROMEOS) 664 #if defined(OS_CHROMEOS)
651 // Read and cache ChromeOS version from file, 665 // Read and cache ChromeOS version from file,
652 // to be used from inside the sandbox. 666 // to be used from inside the sandbox.
653 int32 major_version, minor_version, bugfix_version; 667 int32 major_version, minor_version, bugfix_version;
654 base::SysInfo::OperatingSystemVersionNumbers( 668 base::SysInfo::OperatingSystemVersionNumbers(
655 &major_version, &minor_version, &bugfix_version); 669 &major_version, &minor_version, &bugfix_version);
656 #endif 670 #endif
657 } 671 }
658 672
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 774
761 content::ContentRendererClient* 775 content::ContentRendererClient*
762 ChromeMainDelegate::CreateContentRendererClient() { 776 ChromeMainDelegate::CreateContentRendererClient() {
763 return &g_chrome_content_renderer_client.Get(); 777 return &g_chrome_content_renderer_client.Get();
764 } 778 }
765 779
766 content::ContentUtilityClient* 780 content::ContentUtilityClient*
767 ChromeMainDelegate::CreateContentUtilityClient() { 781 ChromeMainDelegate::CreateContentUtilityClient() {
768 return &g_chrome_content_utility_client.Get(); 782 return &g_chrome_content_utility_client.Get();
769 } 783 }
OLDNEW
« no previous file with comments | « chrome/app/breakpad_linux.cc ('k') | chrome/browser/android/crash_dump_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698