Issue 11189060: Add controlled setting indicator for proxy configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11189060: Add controlled setting indicator for proxy configuration (Closed)

Created:
8 years, 2 months ago by bartfab (slow)

Modified:
8 years, 2 months ago

Reviewers:
Joao da Silva, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add controlled setting indicator for proxy configuration This CL adds a controlled setting indicator that shows when the proxy configuration is managed by policy or an extension. BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162980

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -13 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/options/controlled_setting.js	View		1 chunk	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/options/core_options_handler.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/policy/policy_test_cases.json	View	1	6 chunks	+30 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

bartfab (slow)

Hi James, could you take a look at the UI part of this CL? Hi ...

8 years, 2 months ago (2012-10-18 13:47:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11189060/2001

8 years, 2 months ago (2012-10-19 09:56:45 UTC) #4

Change committed as 162980