Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11189039: Adding a fast path for parsing index keys. (Closed)

Created:
8 years, 2 months ago by Toon Verwaest
Modified:
8 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Adding a fast path for parsing index keys. Reduces overhead on http://code.google.com/p/chromium/issues/detail?id=156379 from 360ms down to 255ms. Committed: https://code.google.com/p/v8/source/detail?r=12761

Patch Set 1 : u #

Total comments: 5

Patch Set 2 : u #

Patch Set 3 : Use kMaxUInt32 as suggested #

Patch Set 4 : Make it look exactly the same as ComputeArrayIndex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M src/json-parser.h View 1 2 3 2 chunks +41 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
8 years, 2 months ago (2012-10-18 09:20:16 UTC) #1
Yang
String::ComputeArrayIndex seems to do this more cleverly. Maybe we can just inline part of it ...
8 years, 2 months ago (2012-10-18 13:45:32 UTC) #2
Yang
On 2012/10/18 13:45:32, Yang wrote: > String::ComputeArrayIndex seems to do this more cleverly. Maybe we ...
8 years, 2 months ago (2012-10-18 14:09:50 UTC) #3
Toon Verwaest
addressed comments https://chromiumcodereview.appspot.com/11189039/diff/2001/src/json-parser.h File src/json-parser.h (right): https://chromiumcodereview.appspot.com/11189039/diff/2001/src/json-parser.h#newcode305 src/json-parser.h:305: int position = position_; On 2012/10/18 13:45:32, ...
8 years, 2 months ago (2012-10-18 14:15:25 UTC) #4
Toon Verwaest
8 years, 2 months ago (2012-10-18 14:30:01 UTC) #5
Used kMaxUInt32 as suggested.

Powered by Google App Engine
This is Rietveld 408576698