Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 11189031: Add iOS support to the chrome/ resource gyp/gypi files (Closed)

Created:
8 years, 2 months ago by stuartmorgan
Modified:
8 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add iOS support to the chrome/ resource gyp/gypi files Excludes resources that aren't used on iOS. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162575

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -78 lines) Patch
M chrome/chrome_repack_chrome.gypi View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/chrome_repack_pseudo_locales.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/chrome_resources.gyp View 9 chunks +81 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
Let me know if you'd rather I find another owner for these kinds of changes; ...
8 years, 2 months ago (2012-10-17 11:37:39 UTC) #1
Nico
LGTM I don't mind reviewing stuff like this. Gives me at least some idea about ...
8 years, 2 months ago (2012-10-17 17:06:28 UTC) #2
stuartmorgan
https://codereview.chromium.org/11189031/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (left): https://codereview.chromium.org/11189031/diff/1/chrome/chrome_resources.gyp#oldcode57 chrome/chrome_resources.gyp:57: 'variables': { On 2012/10/17 17:06:28, Nico wrote: > You ...
8 years, 2 months ago (2012-10-17 20:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11189031/1
8 years, 2 months ago (2012-10-17 20:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11189031/15001
8 years, 2 months ago (2012-10-17 21:57:40 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 23:58:08 UTC) #6
Change committed as 162575

Powered by Google App Engine
This is Rietveld 408576698