Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 11189027: GVD: DestroyTextures() when destroying. (Closed)

Created:
8 years, 2 months ago by Pawel Osciak
Modified:
8 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

GVD: DestroyTextures() when destroying. GVD should release its references to textures when it Destroy()s VDA or when it is deleted. It's safe to do so, as the VDAs should keep their own references to those textures if they are still using them (normally achieved via binding them to XPixmaps or EGLImages). BUG=156251 TEST=manual playbacks, refreshes, tab closes, etc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162400

Patch Set 1 #

Total comments: 1

Patch Set 2 : ~ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M media/filters/gpu_video_decoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Pawel Osciak
8 years, 2 months ago (2012-10-17 00:42:17 UTC) #1
Pawel Osciak
8 years, 2 months ago (2012-10-17 00:44:36 UTC) #2
Ami GONE FROM CHROMIUM
LGTM % nit https://codereview.chromium.org/11189027/diff/1/media/filters/gpu_video_decoder.cc File media/filters/gpu_video_decoder.cc (right): https://codereview.chromium.org/11189027/diff/1/media/filters/gpu_video_decoder.cc#newcode198 media/filters/gpu_video_decoder.cc:198: // It's safe to delete textures ...
8 years, 2 months ago (2012-10-17 00:48:09 UTC) #3
Pawel Osciak
8 years, 2 months ago (2012-10-17 00:53:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11189027/5001
8 years, 2 months ago (2012-10-17 00:53:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11189027/5001
8 years, 2 months ago (2012-10-17 01:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/11189027/5001
8 years, 2 months ago (2012-10-17 11:20:51 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 14:21:30 UTC) #8
Change committed as 162400

Powered by Google App Engine
This is Rietveld 408576698