Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 11189026: Remove TabContents from geolocation. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)
Modified:
8 years, 2 months ago
Reviewers:
John Knottenbelt
CC:
chromium-reviews
Visibility:
Public.

Description

Remove TabContents from geolocation. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 5 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 2 months ago (2012-10-17 00:03:25 UTC) #1
John Knottenbelt
lgtm. Thanks, Avi.
8 years, 2 months ago (2012-10-17 10:09:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11189026/1
8 years, 2 months ago (2012-10-17 13:19:20 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 14:36:54 UTC) #4
Change committed as 162408

Powered by Google App Engine
This is Rietveld 408576698