Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 11189023: Renamed Calculator app's non-DOM "events" to "inputs". (Closed)

Created:
8 years, 2 months ago by dharcourt
Modified:
8 years, 2 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Renamed Calculator app's non-DOM "events" to "inputs". The inputs to the calculator model were called "events". Comments in http://crreview.com/11099051 indicate this causes confusion when those are mixed with the totally different DOM events also used in view.js. With this change, the calculator model inputs were renamed "inputs" to avoid that confusion. No functionality was changed and tests pass after the test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162366

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M chrome/common/extensions/docs/examples/apps/calculator/app/model.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/apps/calculator/app/view.js View 1 chunk +44 lines, -44 lines 1 comment Download
M chrome/common/extensions/docs/examples/apps/calculator/tests/model_test_utilities.js View 3 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dharcourt
Changes only in variable names, method names, and comments, to address comments from a previous ...
8 years, 2 months ago (2012-10-16 23:15:20 UTC) #1
miket_OOO
lgtm
8 years, 2 months ago (2012-10-16 23:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11189023/1
8 years, 2 months ago (2012-10-16 23:42:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11189023/1
8 years, 2 months ago (2012-10-17 11:20:44 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 12:44:01 UTC) #5
Change committed as 162366

Powered by Google App Engine
This is Rietveld 408576698