fix for 156227, 153077, 134093

fix for 156227, 153077, 134093

The fix for 153077 (10977088) was reverted because the ash_unittests failed for non ChromeOS. The only change is that I moved "#if defined(OS_CHROMEOS)" to encompass the whole newly added test:
AcceleratorControllerTest.DisallowedAtModalWindow
in file:
ash/accelerators/accelerator_controller_unittest.cc

see also: 
http://code.google.com/p/chromium/issues/detail?id=156227
https://codereview.chromium.org/11189021

http://code.google.com/p/chromium/issues/detail?id=153077
https://chromiumcodereview.appspot.com/10977088/

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

BUG=156227
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162388

[sschmitz, 2012-10-16 23:01:16]

Fix for reverted CL. The only change w.r.t. earlier CL is that "#if
defined(OS_CHROMEOS)" was moved to encompass the whole newly added unittest.

[Daniel Erat, 2012-10-16 23:22:29]

lgtm

https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
File ash/accelerators/accelerator_controller_unittest.cc (right):

https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
ash/accelerators/accelerator_controller_unittest.cc:1039: #if
defined(OS_CHROMEOS)
nit: do you mind just ifdef-ing out the test itself instead of only its
contents?  (suggesting this based on e.g. base/sys_info_unittest.cc)

[sschmitz, 2012-10-16 23:52:43]

Great idea - done!

https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
File ash/accelerators/accelerator_controller_unittest.cc (right):

https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
ash/accelerators/accelerator_controller_unittest.cc:1039: #if
defined(OS_CHROMEOS)
On 2012/10/16 23:22:29, Daniel Erat wrote:
> nit: do you mind just ifdef-ing out the test itself instead of only its
> contents?  (suggesting this based on e.g. base/sys_info_unittest.cc)

Done.

[Yusuke Sato, 2012-10-17 00:06:43]

lgtm

FYI: just in case you're not aware of these bots: you can check if your CL works
fine on Win/Linux Aura by 'git try -b win_aura,linux_aura'.

On 2012/10/16 23:52:43, sschmitz wrote:
> Great idea - done!
> 
>
https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
> File ash/accelerators/accelerator_controller_unittest.cc (right):
> 
>
https://codereview.chromium.org/11189021/diff/1/ash/accelerators/accelerator_...
> ash/accelerators/accelerator_controller_unittest.cc:1039: #if
> defined(OS_CHROMEOS)
> On 2012/10/16 23:22:29, Daniel Erat wrote:
> > nit: do you mind just ifdef-ing out the test itself instead of only its
> > contents?  (suggesting this based on e.g. base/sys_info_unittest.cc)
> 
> Done.

[commit-bot: I haz the power, 2012-10-17 00:47:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11189021/11001

[commit-bot: I haz the power, 2012-10-17 11:20:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11189021/11001

[commit-bot: I haz the power, 2012-10-17 13:30:32]

Change committed as 162388