Issue 11188040: Automatically use ATL from Windows Driver Kit for SDK-only or Visual Studio Express setup.

Issue 11188040: Automatically use ATL from Windows Driver Kit for SDK-only or Visual Studio Express setup. (Closed)

Created:
8 years, 2 months ago by alexeypa (please no reviews)

Modified:
8 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Automatically use ATL from Windows Driver Kit for SDK-only or Visual Studio Express setup. This CL simplifies the additional configuration steps that SDK-only or Visual Studio Express setup requires. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162666

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix non Windows platforms and consolidate all WDK-based ATL settings #

Patch Set 3 : rebased #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -14 lines)			Patch
	M	build/common.gypi	View	1	3 chunks	+49 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://chromiumcodereview.appspot.com/11188040/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/11188040/diff/1/build/common.gypi#newcode3390 build/common.gypi:3390: '<(windows_driver_kit_path)/inc/mfc42', we need the mfc headers but no ...

8 years, 2 months ago (2012-10-17 18:26:20 UTC) #2

alexeypa (please no reviews)

https://chromiumcodereview.appspot.com/11188040/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/11188040/diff/1/build/common.gypi#newcode3390 build/common.gypi:3390: '<(windows_driver_kit_path)/inc/mfc42', On 2012/10/17 18:26:20, scottmg wrote: > we need ...

8 years, 2 months ago (2012-10-17 22:17:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11188040/2011

8 years, 2 months ago (2012-10-18 04:52:19 UTC) #4

Change committed as 162666

Expand Messages | Collapse Messages