Issue 11187058: Add flag to enable web content to invoke web intents.

Issue 11187058: Add flag to enable web content to invoke web intents. (Closed)

Created:
8 years, 2 months ago by Greg Billock

Modified:
8 years, 1 month ago

Reviewers:
darin (slow to review), James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add flag to enable web content to invoke web intents. R=jhawkins@chromium.org,darin@chromium.org BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164124

Patch Set 2 : Change flag name #

Patch Set 3 : Exclude ChromeOS #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc#newcode966 chrome/browser/about_flags.cc:966: "web-intents-enabled-for-web-content", I think I like --enable-web-intents-invocation better, since this ...

8 years, 2 months ago (2012-10-18 21:02:08 UTC) #2

Greg Billock

https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc#newcode966 chrome/browser/about_flags.cc:966: "web-intents-enabled-for-web-content", sounds good to me On 2012/10/18 21:02:08, James ...

8 years, 2 months ago (2012-10-18 22:03:02 UTC) #3

Greg Billock

On 2012/10/18 22:03:02, Greg Billock wrote: > https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc > File chrome/browser/about_flags.cc (right): > > https://codereview.chromium.org/11187058/diff/1/chrome/browser/about_flags.cc#newcode966 ...

8 years, 2 months ago (2012-10-23 20:09:15 UTC) #4

Greg Billock

On 2012/10/23 20:45:04, James Hawkins wrote: > lgtm ChromeOS ECHO is using this functionality. We ...

8 years, 2 months ago (2012-10-24 05:51:39 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11187058/17001

8 years, 1 month ago (2012-10-25 16:52:07 UTC) #7

Change committed as 164124

Expand Messages | Collapse Messages