tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py - Issue 11187036: Android: start upstreaming some of our perf tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

Issue 11187036: Android: start upstreaming some of our perf tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert adb_commands Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/surface_stats_collector.py ('k') | tools/chrome_remote_control/chrome_remote_control/android_platform.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

index ec12c906f6f41dae749c1e4f91d094a57b1c2134..a0d4b04da800467fdc61a9af0267197d6e8c11a1 100644

--- a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

+++ b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

@@ -10,6 +10,7 @@ import subprocess

from chrome_remote_control import adb_commands

from chrome_remote_control import android_browser_backend

+from chrome_remote_control import android_platform

from chrome_remote_control import browser

from chrome_remote_control import possible_browser

@@ -52,7 +53,10 @@ class PossibleAndroidBrowser(possible_browser.PossibleBrowser):

def Create(self):

backend = android_browser_backend.AndroidBrowserBackend(

self._options, *self._args)

- return browser.Browser(backend)

+ platform = android_platform.AndroidPlatform(

+ self._args[0].Adb(), self._args[1],

+ self._args[1] + self._args[4])

+ return browser.Browser(backend, platform)

def FindAllAvailableBrowsers(options, logging=real_logging):

"""Finds all the desktop browsers available on this machine."""