Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11187030: Tell profile sync svc to use all datatypes when the user chooses the default (Closed)

Created:
8 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Tell profile sync svc to use all datatypes when the user chooses the default sync options with one click sign in. BUG=154940 TEST=Create a new profile. Don't use sync promo. Sign in to gmail and use the one-click sign in feature. In the bubble that shows up pointing to the wrench menu, make sure to use the default option and not the advanced option. Stop and restart chrome. Go to the settings page and click the "Advanced sync settings..." button. Make sure all data types are selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162479

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Nicolas, Please take a look. Thanks.
8 years, 2 months ago (2012-10-17 15:45:32 UTC) #1
Nicolas Zea
LGTM
8 years, 2 months ago (2012-10-17 17:17:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11187030/1
8 years, 2 months ago (2012-10-17 17:21:45 UTC) #3
commit-bot: I haz the power
Change committed as 162479
8 years, 2 months ago (2012-10-17 19:11:52 UTC) #4
tim (not reviewing)
8 years, 2 months ago (2012-10-22 19:38:46 UTC) #5
http://codereview.chromium.org/11187030/diff/1/chrome/browser/ui/sync/one_cli...
File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (left):

http://codereview.chromium.org/11187030/diff/1/chrome/browser/ui/sync/one_cli...
chrome/browser/ui/sync/one_click_signin_sync_starter.cc:71: // Just kick off the
sync machine, no need to configure it first.
nit - comment needs update next time you're in the neighborhood.

Powered by Google App Engine
This is Rietveld 408576698