Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 11187010: Rename SurfaceState to MemoryManagerState (Closed)

Created:
8 years, 2 months ago by ccameron
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Rename SurfaceState to MemoryManagerState. The state in this structure is used only by the GPU memory manager, so the name should reflect this. Move GpuCommandBufferStubBase state is used only by the GPU memory manager into MemoryManagerState. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162354

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Patch Set 3 : Fix trybot warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -85 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 4 chunks +16 lines, -16 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 6 chunks +18 lines, -27 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 4 chunks +17 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 9 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ccameron
Some upcoming changes will require tracking more memory manager related state. The state used by ...
8 years, 2 months ago (2012-10-16 20:49:01 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/11187010/diff/1/content/common/gpu/gpu_command_buffer_stub.h File content/common/gpu/gpu_command_buffer_stub.h (right): https://codereview.chromium.org/11187010/diff/1/content/common/gpu/gpu_command_buffer_stub.h#newcode56 content/common/gpu/gpu_command_buffer_stub.h:56: // Use time is determined by the last ...
8 years, 2 months ago (2012-10-16 22:06:01 UTC) #2
ccameron
Thanks! https://codereview.chromium.org/11187010/diff/1/content/common/gpu/gpu_command_buffer_stub.h File content/common/gpu/gpu_command_buffer_stub.h (right): https://codereview.chromium.org/11187010/diff/1/content/common/gpu/gpu_command_buffer_stub.h#newcode56 content/common/gpu/gpu_command_buffer_stub.h:56: // Use time is determined by the last ...
8 years, 2 months ago (2012-10-16 22:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11187010/4001
8 years, 2 months ago (2012-10-16 22:30:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11187010/4001
8 years, 2 months ago (2012-10-16 22:35:27 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-16 22:56:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11187010/12001
8 years, 2 months ago (2012-10-16 23:27:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11187010/12001
8 years, 2 months ago (2012-10-17 11:17:56 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 12:08:08 UTC) #9
Change committed as 162354

Powered by Google App Engine
This is Rietveld 408576698