Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 11187004: MemoryDetails::UpdateHistograms() needs an entry for PROCESS_TYPE_PPAPI_BROKER (Closed)

Created:
8 years, 2 months ago by Joe Thomas
Modified:
8 years, 2 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

MemoryDetails::UpdateHistograms() needs an entry for PROCESS_TYPE_PPAPI_BROKER Added PROCESS_TYPE_PPAPI_BROKER case Patch from Joe Thomas <mhx348@motorola.com>;. BUG=142923 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/memory_details.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Joe Thomas
8 years, 2 months ago (2012-10-16 17:21:25 UTC) #1
James Cook
LGTM. We'll need to add an entry to our internal histograms description file for the ...
8 years, 2 months ago (2012-10-16 17:33:36 UTC) #2
Joe Thomas
On 2012/10/16 17:33:36, James Cook (Chromium) wrote: > LGTM. We'll need to add an entry ...
8 years, 2 months ago (2012-10-16 17:36:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/11187004/1
8 years, 2 months ago (2012-10-16 17:36:50 UTC) #4
commit-bot: I haz the power
Presubmit check for 11187004-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-16 17:36:58 UTC) #5
Joe Thomas
Hi Scott, Could you please review this CL? Pre-submit check failed in CQ before as ...
8 years, 2 months ago (2012-10-16 17:48:49 UTC) #6
sky
LGTM
8 years, 2 months ago (2012-10-16 20:58:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/11187004/1
8 years, 2 months ago (2012-10-16 20:59:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/11187004/1
8 years, 2 months ago (2012-10-16 22:21:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/11187004/1
8 years, 2 months ago (2012-10-17 07:17:52 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 09:19:43 UTC) #11
Change committed as 162336

Powered by Google App Engine
This is Rietveld 408576698