Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 11186014: Handles unknown TARGET_PRODUCT in envsetup.sh (Closed)

Created:
8 years, 2 months ago by Jinsuk Kim (do not use this)
Modified:
8 years, 1 month ago
Reviewers:
joth, Yaron, bulach, navabi1
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Handles unknown TARGET_PRODUCT in envsetup.sh Android comes with a set of build target products (such as soju, trygon) to build and run Chrome for Android on. When it gets ported to other devices, however, the build env will likely have its own build targets for them, unknown to pre-defined build environment. This CL tries to let Chrome for Android build env support those unknown target products. Rather than bloating the env setup script with those new target names, it tries getting TARGET_ARCH_VARIANT by calling the function get_build_var() (if available) defined in ${ANDROID_ROOT}/build/envsetup.sh to see if the variable was set up by lunch command. This will help Chrome for Android build for new, upcoming devices. TEST=Built successfully with following targets: - soju(armv7-a-neon) - trygon(arm7-a) - full(armv5te) - full_x86(x86) - a custom target whose TARGET_ARCH_VARIANT is armv7-a BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +29 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
seems reasonable to me but +joth whom I believe was talking about doing something similar.
8 years, 2 months ago (2012-10-18 19:55:08 UTC) #1
joth
+bulach I think the suggestion was to remove the list of 'supported' products and just ...
8 years, 2 months ago (2012-10-18 20:12:41 UTC) #2
Jinsuk Kim (do not use this)
Well then I hope this CL could be a stopgap measure for it. I'm ok ...
8 years, 2 months ago (2012-10-19 07:10:14 UTC) #3
Jinsuk Kim (do not use this)
How about adding tech_arch= (or cpu=) param to envsetup.sh like following? . build/android/envsetup.sh # defaults ...
8 years, 2 months ago (2012-10-23 01:22:18 UTC) #4
Jinsuk Kim (do not use this)
s/tech_arch/target_arch/g On 2012/10/23 01:22:18, jinsukkim wrote: > How about adding tech_arch= (or cpu=) param to ...
8 years, 2 months ago (2012-10-23 01:25:38 UTC) #5
bulach
agreed, sounds reasonable! thanks! I'm cc:ing navabi as well, as it may have some implications ...
8 years, 2 months ago (2012-10-23 13:49:45 UTC) #6
Jinsuk Kim (do not use this)
8 years, 2 months ago (2012-10-24 04:51:08 UTC) #7
On 2012/10/23 13:49:45, bulach wrote:
> agreed, sounds reasonable! thanks! I'm cc:ing navabi as well, as it may have
> some implications on some his bots..

Created a new CL https://codereview.chromium.org/11260008 that addresses the
point made here. Thanks.

Powered by Google App Engine
This is Rietveld 408576698