Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 11185060: Add a test to check the initial register state for a new thread (Closed)

Created:
8 years, 2 months ago by Mark Seaborn
Modified:
8 years, 2 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add a test to check the initial register state for a new thread This checks that no register starts off with an undefined value (i.e. a value that comes from uninitialised memory, or that was leaked from trusted code in another way). We account for all register values. Also fix REGS_SAVER_FUNC() on ARM so that the routine it defines is correctly aligned when two or more REGS_SAVER_FUNC() are used in the same source file. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2236 TEST=run_syscall_return_regs_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10061

Patch Set 1 #

Patch Set 2 : Fix TSan problem #

Patch Set 3 : Use longer name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -26 lines) Patch
M tests/common/register_set.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/syscall_return_regs/nacl.scons View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests/syscall_return_regs/syscall_return_regs_test.c View 1 2 5 chunks +104 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years, 2 months ago (2012-10-18 23:48:38 UTC) #1
bradn
8 years, 2 months ago (2012-10-22 17:48:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698