Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 11185059: Removed CXX_target for Android (Closed)

Created:
8 years, 2 months ago by michaelbai
Modified:
8 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Removed CXX_target for Android Don't rely on compiler_version.py, we pass in the gcc_version for Android Also revert the previous compiler_version.py change. BUG=143889 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -49 lines) Patch
M build/android/envsetup.sh View 1 chunk +2 lines, -14 lines 0 comments Download
M build/android/envsetup_functions.sh View 2 chunks +4 lines, -0 lines 0 comments Download
M build/compiler_version.py View 1 chunk +14 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaelbai
8 years, 2 months ago (2012-10-18 20:00:54 UTC) #1
Yaron
lgtm
8 years, 2 months ago (2012-10-18 20:06:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11185059/1
8 years, 2 months ago (2012-10-18 20:11:01 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 22:08:08 UTC) #4
Change committed as 162808

Powered by Google App Engine
This is Rietveld 408576698