Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 11185056: Adding stages for request headers and 3rd party attributes (Closed)

Created:
8 years, 2 months ago by vabr (Chromium)
Modified:
8 years, 2 months ago
Reviewers:
battre
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Adding stages for request headers and 3rd party attributes I forgot to do this in CLs http://codereview.chromium.org/10982044/ and http://codereview.chromium.org/11038031/. BUG=112155, 143662, 135606 TEST=N/A (docs changes only) TBR=cduvall@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162770

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Dominic, I just realised I missed this in the docs when adding the new ...
8 years, 2 months ago (2012-10-18 17:54:34 UTC) #1
battre
lgtm
8 years, 2 months ago (2012-10-18 18:00:24 UTC) #2
vabr (Chromium)
Thanks, Dominic! Adding cduvall@ in TBR for an OWNERS rubber stamp and sending to CQ. ...
8 years, 2 months ago (2012-10-18 18:08:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/11185056/1
8 years, 2 months ago (2012-10-18 18:08:29 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 20:08:25 UTC) #5
Change committed as 162770

Powered by Google App Engine
This is Rietveld 408576698