Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 11185002: No need to support dasher domains. (Closed)

Created:
8 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 2 months ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

No need to support old style dasher domains. BUG=137118 TEST=See unit tests, not called in any code yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M google_apis/gaia/gaia_auth_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Joi, Please take a look. Thanks.
8 years, 2 months ago (2012-10-16 15:04:48 UTC) #1
Jói
LGTM if you're sure :)
8 years, 2 months ago (2012-10-16 15:41:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11185002/1
8 years, 2 months ago (2012-10-16 15:47:21 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 18:34:26 UTC) #4
Change committed as 162184

Powered by Google App Engine
This is Rietveld 408576698