Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 11184050: [content shell] add support for getting tests from the command line. (Closed)

Created:
8 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

[content shell] add support for getting tests from the command line. Related to this, parse a single dash on the command line as argument, instead of a switch with no value and name BUG=111316 TEST=out/Debug/content_shell --dump-render-tree path/to/test.html works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162947

Patch Set 1 #

Total comments: 4

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M base/command_line.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/command_line_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/shell/shell_browser_main.cc View 1 2 3 4 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
plz review Brett: base/command_line* Marja: content/shell/*
8 years, 2 months ago (2012-10-18 20:45:22 UTC) #1
marja
http://codereview.chromium.org/11184050/diff/1/base/command_line.cc File base/command_line.cc (right): http://codereview.chromium.org/11184050/diff/1/base/command_line.cc#newcode54 base/command_line.cc:54: if (prefix_length == 0 || prefix_length == string.length()) nit: ...
8 years, 2 months ago (2012-10-18 20:53:57 UTC) #2
jochen (gone - plz use gerrit)
http://codereview.chromium.org/11184050/diff/1/base/command_line.cc File base/command_line.cc (right): http://codereview.chromium.org/11184050/diff/1/base/command_line.cc#newcode54 base/command_line.cc:54: if (prefix_length == 0 || prefix_length == string.length()) On ...
8 years, 2 months ago (2012-10-18 21:06:42 UTC) #3
marja
thx, lgtm.
8 years, 2 months ago (2012-10-18 21:12:49 UTC) #4
jochen (gone - plz use gerrit)
-brettw +jar Jim, can you plz review base/command_line* ?
8 years, 2 months ago (2012-10-18 23:12:08 UTC) #5
jar (doing other things)
lgtm
8 years, 2 months ago (2012-10-19 02:30:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11184050/6
8 years, 2 months ago (2012-10-19 05:17:53 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 06:20:01 UTC) #8
Change committed as 162947

Powered by Google App Engine
This is Rietveld 408576698