Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 11184006: Eagerly follow transitions to existing maps while json parsing. (Closed)

Created:
8 years, 2 months ago by Toon Verwaest
Modified:
8 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Eagerly follow transitions to existing maps while json parsing. Committed: https://code.google.com/p/v8/source/detail?r=12747

Patch Set 1 : Eagerly transition but directly set properties #

Patch Set 2 : Inline #

Total comments: 6

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M src/json-parser.h View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL.
8 years, 2 months ago (2012-10-16 17:38:13 UTC) #1
danno
https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h#newcode1418 src/objects-inl.h:1418: int size = As discussed, please convert this into ...
8 years, 2 months ago (2012-10-17 13:54:23 UTC) #2
Toon Verwaest
Addressed comments. https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/11184006/diff/2003/src/objects-inl.h#newcode1418 src/objects-inl.h:1418: int size = On 2012/10/17 13:54:23, danno ...
8 years, 2 months ago (2012-10-17 14:03:40 UTC) #3
danno
8 years, 2 months ago (2012-10-17 14:07:49 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698