Issue 11184003: Added support for trace params to MakeURL. This fixes an issue where the trace= url parameter was s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11184003: Added support for trace params to MakeURL. This fixes an issue where the trace= url parameter was s… (Closed)

Created:
8 years, 2 months ago by sullivan

Modified:
8 years, 2 months ago

Reviewers:
cmp, tonyg

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/tools/perf.git@master

Visibility:
Public.

More Reviews

Description

Added support for trace params to MakeURL. This fixes an issue where the trace= url parameter was set and history was not set, and the page redirected to a url with a parameter trace=[object Object] BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162188

Patch Set 1 #

Total comments: 3

Patch Set 2 : Cleaned up code #

Patch Set 3 : Removed extra line #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	dashboard/ui/js/common.js	View	1 2	1 chunk	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm Nice catch. Just style nits below. http://codereview.chromium.org/11184003/diff/1/dashboard/ui/js/common.js File dashboard/ui/js/common.js (right): http://codereview.chromium.org/11184003/diff/1/dashboard/ui/js/common.js#newcode93 dashboard/ui/js/common.js:93: var new_param ...

8 years, 2 months ago (2012-10-16 18:28:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/11184003/4001

8 years, 2 months ago (2012-10-16 18:38:18 UTC) #4

Change committed as 162188

Expand Messages | Collapse Messages