Issue 11183049: Changes on the Input method for metro ash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11183049: Changes on the Input method for metro ash (Closed)

Created:
8 years, 2 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 2 months ago

Reviewers:
Yusuke Sato, Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, James Su, sadrul, penghuang+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Changes on the Input method for metro ash With this change and http://codereview.chromium.org/11194044/ you get some keyboard love in metro ash, like delete and tab work but no regular text input. BUG=151718 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163030

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
M	ui/aura/shared/input_method_event_filter.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/base/ime/input_method.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/ime/mock_input_method.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/base/ime/mock_input_method.cc	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/base/test/dummy_input_method.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/test/dummy_input_method.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

8 years, 2 months ago (2012-10-19 01:38:22 UTC) #4

LGTM

http://codereview.chromium.org/11183049/diff/1007/ui/base/ime/mock_input_meth...
File ui/base/ime/mock_input_method.cc (right):

http://codereview.chromium.org/11183049/diff/1007/ui/base/ime/mock_input_meth...
ui/base/ime/mock_input_method.cc:11: #include "ui/base/events/event.h"
nit: wrong order

Expand Messages | Collapse Messages