Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 11183029: Don't reject extension list policies with invalid entries. (Closed)

Created:
8 years, 2 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 2 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Don't reject extension list policies with invalid entries. Even if there's an entry that doesn't have a valid extension ID, we should allow the remaining entries to be processed. BUG=chromium:131065 TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162358

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M chrome/browser/policy/configuration_policy_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_unittest.cc View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mattias Nissler (ping if slow)
Here's a quick fix for an issue reported by the KIR people.
8 years, 2 months ago (2012-10-17 08:56:48 UTC) #1
Joao da Silva
lgtm https://codereview.chromium.org/11183029/diff/1/chrome/browser/policy/configuration_policy_handler.cc File chrome/browser/policy/configuration_policy_handler.cc (right): https://codereview.chromium.org/11183029/diff/1/chrome/browser/policy/configuration_policy_handler.cc#newcode260 chrome/browser/policy/configuration_policy_handler.cc:260: // Check that the list contains valid extension ...
8 years, 2 months ago (2012-10-17 09:26:49 UTC) #2
Mattias Nissler (ping if slow)
https://codereview.chromium.org/11183029/diff/1/chrome/browser/policy/configuration_policy_handler.cc File chrome/browser/policy/configuration_policy_handler.cc (right): https://codereview.chromium.org/11183029/diff/1/chrome/browser/policy/configuration_policy_handler.cc#newcode260 chrome/browser/policy/configuration_policy_handler.cc:260: // Check that the list contains valid extension ID ...
8 years, 2 months ago (2012-10-17 09:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/11183029/5001
8 years, 2 months ago (2012-10-17 09:47:42 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 12:15:45 UTC) #5
Change committed as 162358

Powered by Google App Engine
This is Rietveld 408576698