Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 11183025: Use third_party/pexpect in android pylib (Closed)

Created:
8 years, 2 months ago by nduca
Modified:
8 years, 2 months ago
Reviewers:
bulach, Isaac (away)
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Use third_party/pexpect in android pylib BUG=154343 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162519

Patch Set 1 #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M build/android/lighttpd_server.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/forwarder.py View 2 chunks +2 lines, -1 line 0 comments Download
A build/android/pylib/pexpect.py View 1 1 chunk +16 lines, -0 lines 0 comments Download
M build/android/pylib/test_package.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/test_package_apk.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/test_package_executable.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nduca
Hey folks, I couldn't quite see a convention that y'all use when you import libs ...
8 years, 2 months ago (2012-10-17 05:11:31 UTC) #1
bulach
lgtm, nice technique, thanks!
8 years, 2 months ago (2012-10-17 09:57:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11183025/3001
8 years, 2 months ago (2012-10-17 18:41:45 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 21:03:22 UTC) #4
Change committed as 162519

Powered by Google App Engine
This is Rietveld 408576698