components/renderer_context_menu/context_menu_content_type.h - Issue 1117893002: Moving extension code out of "components/" to avoid layering violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/context_menu_content_type.h

Issue 1117893002: Moving extension code out of "components/" to avoid layering violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/render_view_context_menu.cc ('K') | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | components/renderer_context_menu/context_menu_content_type.cc » ('j') | components/renderer_context_menu/context_menu_content_type.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/context_menu_content_type.h

diff --git a/components/renderer_context_menu/context_menu_content_type.h b/components/renderer_context_menu/context_menu_content_type.h

index c1e6a74f375c9ccdd7a5a7c914c29607a0e905b9..a54e72ccf7e89bd4d7397bc2a21107bc8244c6d9 100644

--- a/components/renderer_context_menu/context_menu_content_type.h

+++ b/components/renderer_context_menu/context_menu_content_type.h

@@ -68,9 +68,7 @@ class ContextMenuContentType {

protected:

const content::ContextMenuParams& params() const { return params_; }

- const extensions::Extension* GetExtension() const;

- const content::WebContents* source_web_contents() const {

+ content::WebContents* source_web_contents() const {

lazyboy 2015/04/30 16:33:31 Ah this is sad, can you add a TODO(lazyboy) to mak

Deepak 2015/05/02 06:25:20 Done.

return source_web_contents_;

}