Selective build clobbering feature (landmines.py and android build scripts).

build/landmines.py

+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+'''
+This file holds a list of reasons why a particular build needs to be clobbered
+(or a list of 'landmines').
+
+This script runs every build as a hook. If it detects that the build should
+be clobbered, it will touch the file <build_dir>/.landmine_triggered. The
+various build scripts will then check for the presence of this file and clobber
+accordingly. The script will also emit the reasons for the clobber to stdout.
+
+A landmine is tripped when a builder checks out a different revision, and the
+diff between the new landmines and the old ones is non-null. At this point, the
+build is clobbered.
+'''
+
+import difflib
+import functools
+import gyp_helper
+import os
+import shlex
+import sys
+import time
+
+
+def memoize(default=''):

[M-A Ruel, 2012/10/24 00:40:58]

Please a one-liner docstring. It's a nice trick though, never thought about
that. I don't think '' is a good default, I'd prefer None.

[iannucci, 2012/10/24 04:12:25]

I have '' as the default because get_landmines expects strings back from all
these guys, though looking at it now, I expect a lot less .startswith usage.
I'll make it None.

+  def memoizer(func):
+    val = []
+    @functools.wraps(func)
+    def inner(*args, **kwargs):
+      if not val:
+        ret = func(*args, **kwargs)
+        val.append(ret if ret is not None else default)
+        print '%s -> %r' % (func.__name__, val[0])

[M-A Ruel, 2012/10/24 00:40:58]

Was this for debugging purpose? At best you'd use logging, but I think it's just
better to remove it.

[iannucci, 2012/10/24 04:12:25]

I'd like this to show up in the buildbot logs (very useful for debugging)... is
there a better way to do that?

[M-A Ruel, 2012/10/24 12:16:10]

I just fear spew for devs. You can leave it in and I'll see if I like/hate it.

+      return val[0]
+    return inner
+  return memoizer
+
+
+@memoize()
+def IsWindows():
+  return sys.platform.startswith('win') or sys.platform == 'cygwin'
+
+
+@memoize()
+def IsLinux():
+  return sys.platform.startswith('linux')
+
+
+@memoize()
+def IsMac():
+  return sys.platform.startswith('darwin')
+
+
+@memoize()
+def gyp_defines():
+  return dict(arg.split('=', 1)
+      for arg in shlex.split(os.environ.get('GYP_DEFINES', '')))
+
+
+@memoize()
+def distributor():
+  if 'goma' in gyp_defines():
+    return 'goma'
+  elif IsWindows():
+    if 'CHROME_HEADLESS' in os.environ:
+      return 'ib' # use (!goma and headless) as approximation of ib
+
+
+@memoize()
+def platform():
+  if 'OS' in gyp_defines():
+    if 'android' in gyp_defines()['OS']:
+      return 'android'
+    else:
+      return gyp_defines()['OS']
+  elif IsWindows():
+    return 'win'
+  elif IsLinux():
+    return 'linux'
+  else:
+    return 'mac'
+
+
+@memoize()
+def builder():
+  if 'GYP_GENERATORS' in os.environ:
+    # for simplicity, only support the first explicit generator
+    return os.environ['GYP_GENERATORS'].split(',')[0]
+  else:
+    if platform() == 'android':
+      # Good enough for now? Do any android bots use make?
+      return 'ninja'
+    elif platform() == 'ios':
+      return 'xcode'
+    elif IsWindows():
+      return 'msvs'
+    elif IsLinux():
+      return 'make'
+    elif IsMac():
+      return 'xcode'
+    else:
+      assert False, 'Don\'t know what builder we\'re using!'
+
+
+def get_landmines(target):
+  '''

[M-A Ruel, 2012/10/24 00:40:58]

Consistent docstring style, we setled for """

[iannucci, 2012/10/24 04:12:25]

And just when I was getting good at using single quotes... ;D

+  ALL LANDMINES ARE DEFINED HERE.
+  target is Release or Debug
+  '''
+  landmines = []
+  add = lambda item: landmines.append(item + '\n')
+
+  if (distributor() == 'goma' and platform() == 'win32' and
+      builder() == 'ninja'):
+    add('Need to clobber winja goma due to backend cwd cache fix.')
+
+  return landmines
+
+
+def get_target_build_dir(build_tool, src_dir, target, is_iphone=False):
+  ret = None
+  if build_tool == 'xcode':
+    ret = os.path.join(src_dir, 'xcodebuild', 'content.build',
+        target + ('-iphoneos' if is_iphone else ''))
+  elif build_tool == 'make':
+    ret = os.path.join(src_dir, 'out', target)
+  elif build_tool == 'ninja':
+    ret = os.path.join(src_dir, 'out', target)
+  elif build_tool == 'msvs':
+    ret = os.path.join(src_dir, 'build', target)
+  elif build_tool == 'scons':
+    ret = os.path.join(src_dir, 'sconsbuild', target)
+  return os.path.abspath(ret)
+
+
+def main():
+  gyp_helper.apply_chromium_gyp_env()
+  src_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
+
+  for target in ('Debug', 'Release'):
+    out_dir = get_target_build_dir(builder(), src_dir, target,
+                                   platform() == 'ios')
+
+    landmines_path = os.path.join(out_dir, '.landmines')
+    if not os.path.exists(out_dir):
+      os.makedirs(out_dir)
+
+    new_landmines = get_landmines(target)
+
+    if not os.path.exists(landmines_path):
+      with open(landmines_path, 'w') as f:
+        f.writelines(new_landmines)
+    else:
+      triggered = os.path.join(out_dir, '.landmines_triggered')
+      with open(landmines_path, 'r') as f:
+        old_landmines = f.readlines()
+      if old_landmines != new_landmines:
+        old_date = time.ctime(os.stat(landmines_path).st_ctime)
+        diff = difflib.unified_diff(old_landmines, new_landmines,
+            fromfile='old_landmines', tofile='new_landmines',
+            fromfiledate=old_date, tofiledate=time.ctime(), n=0)
+
+        with open(triggered, 'w') as f:
+          f.writelines(diff)
+      elif os.path.exists(triggered):
+        # Remove false triggered landmines.
+        os.unlink(triggered)
+
+  return 0
+

[M-A Ruel, 2012/10/24 00:40:58]

2 lines

+if __name__ == '__main__':
+  sys.exit(main())