testserver.py TLS and client auth support on WebSocket.

testserver.py TLS and client auth support on WebSocket.

BUG=136950
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162653

[Takashi Toyoshima, 2012-10-16 08:31:45]

This CL is splited from https://codereview.chromium.org/11085039/ and
https://chromiumcodereview.appspot.com/10703189/.

phajdan.jr,
Could you take a look?

[Paweł Hajdan Jr., 2012-10-16 17:07:24]

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
File net/tools/testserver/testserver.py (right):

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
net/tools/testserver/testserver.py:2264: return
Those failure cases should make the server exit with non-zero exit code.

If you've copied this convention from other places in this file, could you
please also fix those places (possibly in another CL), or add a TODO for now?
Feel free to make that TODO(phajdan.jr).

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
net/tools/testserver/testserver.py:2266: print 'specified trusted client CA file
not found: ' + \
nit: Use parentheses ('...' +
                                 '...')

instead of the backslash \ to continue on the second line.

[Takashi Toyoshima, 2012-10-17 01:18:42]

Thanks.
Could you take another look?

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
File net/tools/testserver/testserver.py (right):

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
net/tools/testserver/testserver.py:2264: return
Other paths need similar fix.
So, just leave TODO in this CL.

https://codereview.chromium.org/11175002/diff/1/net/tools/testserver/testserv...
net/tools/testserver/testserver.py:2266: print 'specified trusted client CA file
not found: ' + \
On 2012/10/16 17:07:24, Paweł Hajdan Jr. wrote:
> nit: Use parentheses ('...' +
>                                  '...')
> 
> instead of the backslash \ to continue on the second line.

Done.

[Paweł Hajdan Jr., 2012-10-17 16:59:11]

https://codereview.chromium.org/11175002/diff/8001/net/tools/testserver/tests...
File net/tools/testserver/testserver.py (right):

https://codereview.chromium.org/11175002/diff/8001/net/tools/testserver/tests...
net/tools/testserver/testserver.py:2272: # TODO(phajdan.jr): Provide non-zero
exit code for these error cases.
Sorry for ambiguity, I intended that to be a TODO only for _existing_ parts of
this file, not for parts being changed. Please fix the changes you've made to
exit with non-zero exit code in this CL.

[Takashi Toyoshima, 2012-10-17 17:54:42]

Can you allow me to split it to another CL?
Currently, every path doesn't return non-zero values for errors. So current
implementation is consistent with existing code.
This CL has plural dependent CLs.
I'd like to land this as soon as possible.

[Paweł Hajdan Jr., 2012-10-17 18:08:08]

Alright, could you then please fix the TODOs from this CL after landing, and
preferably get rest of the file fixed too? I'd be happy to help.

LGTM

[Takashi Toyoshima, 2012-10-18 02:55:52]

Thanks a lot!
I'll make a change for the TODO, soon.

[commit-bot: I haz the power, 2012-10-18 03:03:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11175002/13003

[commit-bot: I haz the power, 2012-10-18 05:05:53]

Change committed as 162653