Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11170002: Hold path by value in gdata::InitiateUploadParams (Closed)

Created:
8 years, 2 months ago by tzik
Modified:
8 years, 2 months ago
Reviewers:
kochi
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

Hold path by value in gdata::InitiateUploadParams BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/google_apis/gdata_operations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
Kochi-san, as we mentioned at http://codereview.chromium.org/11143014/. I think it's better to hold the virtual_path by ...
8 years, 2 months ago (2012-10-16 07:33:33 UTC) #1
kochi
LGTM, thanks!
8 years, 2 months ago (2012-10-16 07:51:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11170002/1
8 years, 2 months ago (2012-10-16 09:05:33 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 11:00:37 UTC) #4 
Change committed as 162121

Powered by Google App Engine
This is Rietveld 408576698