Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h - Issue 1116843002: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

diff --git a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

index 239f2c8a5fcb2da97bfaecb9e9a08bdabfc86607..55e6629708ae503a1a331fcc8695eb28bf22eb0c 100644

--- a/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

+++ b/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h

@@ -15,8 +15,8 @@ class SerializedScriptValueForModulesFactory final : public SerializedScriptValu

public:

SerializedScriptValueForModulesFactory() : SerializedScriptValueFactory() { }

- virtual PassRefPtr<SerializedScriptValue> create(v8::Local<v8::Value>, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, ExceptionState&, v8::Isolate*) override;

- virtual PassRefPtr<SerializedScriptValue> create(const String&, v8::Isolate*) override;

+ virtual PassRefPtr<SerializedScriptValue> create(v8::Isolate*, v8::Local<v8::Value>, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, ExceptionState&) override;

+ virtual PassRefPtr<SerializedScriptValue> create(v8::Isolate*, const String&) override;

protected:

virtual ScriptValueSerializer::Status doSerialize(v8::Local<v8::Value>, SerializedScriptValueWriter&, MessagePortArray*, ArrayBufferArray*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, String& errorMessage, v8::Isolate*) override;