Fix two image case in first run ImageCarousel.

Fix two image case in first run ImageCarousel.

Old behavior:
Two images would get duplicated and user would infitintely scroll
through two images.

New behavior:
We only show two images and user is bound to be between image one
and two.

BUG=394399
Committed: https://crrev.com/cb629bd6b2c3cb074b7003fcf970af139644625a
Cr-Commit-Position: refs/heads/master@{#327390}

[aurimas (slooooooooow), 2015-04-28 20:50:45]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org

[aurimas (slooooooooow), 2015-04-28 20:50:45]

PTAL

[newt (away), 2015-04-28 21:39:04]

https://chromiumcodereview.appspot.com/1116483002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java
(right):

https://chromiumcodereview.appspot.com/1116483002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java:379:
if (mImages.length == 1 && getChildDrawingOrder(VIEW_COUNT, i) > 0) return;
maybe save in a variable

[newt (away), 2015-04-28 21:39:11]

lgtm after comment

[aurimas (slooooooooow), 2015-04-28 21:49:28]

https://chromiumcodereview.appspot.com/1116483002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java
(right):

https://chromiumcodereview.appspot.com/1116483002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java:379:
if (mImages.length == 1 && getChildDrawingOrder(VIEW_COUNT, i) > 0) return;
On 2015/04/28 at 21:39:04, newt wrote:
> maybe save in a variable

Done

[aurimas (slooooooooow), 2015-04-28 21:49:35]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-04-28 21:49:35]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1116483002/#ps20001
(title: "Cache drawingOrder")

[commit-bot: I haz the power, 2015-04-28 21:50:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116483002/20001

[commit-bot: I haz the power, 2015-04-28 23:33:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-28 23:34:09]

Patchset 2 (id:??) landed as
https://crrev.com/cb629bd6b2c3cb074b7003fcf970af139644625a
Cr-Commit-Position: refs/heads/master@{#327390}