Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11155022: Fix accessibility issues on most visited page for android's NTP. (Closed)

Created:
8 years, 2 months ago by Ted C
Modified:
8 years, 2 months ago
Reviewers:
aruslan, Jay Civelli
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix accessibility issues on most visited page for android's NTP. Do not modify the DOM of the most visited page if nothing has changed, which is often the case as the top sites are polled periodically just to make sure they are up to date. Also, moves the event listener to a node with a text attribute that allows it to be selected in accessibility mode. Makes some markup nodes as skippable in accessibility mode by marking them as having empty alt text. BUG=155450 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M chrome/browser/resources/ntp_android/ntp_android.js View 5 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
8 years, 2 months ago (2012-10-15 23:22:06 UTC) #1
Evan Stade
I assume you added me as an OWNER of resources. Instead please add an OWNERS ...
8 years, 2 months ago (2012-10-16 03:00:08 UTC) #2
aruslan
LGTM
8 years, 2 months ago (2012-10-16 18:24:42 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-10-16 18:43:13 UTC) #4
Ted C
@jcivelli for lgtm stamp
8 years, 2 months ago (2012-10-16 18:46:11 UTC) #5
Jay Civelli
lgtm
8 years, 2 months ago (2012-10-16 18:55:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11155022/1
8 years, 2 months ago (2012-10-16 18:58:24 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 21:08:38 UTC) #8
Change committed as 162246

Powered by Google App Engine
This is Rietveld 408576698