White-list the two ssh client webstore ids besides quickoffice.

White-list the two ssh client webstore ids besides quickoffice.

BUG= http://code.google.com/p/chromium-os/issues/detail?id=35298


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162026

[Robert Muth (chromium), 2012-10-15 21:35:32]

PTAL

(still sorting out what is going on with the bots)

[zel, 2012-10-15 21:44:36]

lgtm

[rginda, 2012-10-15 21:45:29]

lgtm

[commit-bot: I haz the power, 2012-10-15 21:47:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertm@chromium.org/11155020/2001

[commit-bot: I haz the power, 2012-10-15 21:47:58]

Presubmit check for 11155020-2001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 4.0s to calculate.

[Ben Goodger (Google), 2012-10-15 21:54:11]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
&& OS CHROMEOS?

[Robert Muth (chromium), 2012-10-15 21:56:06]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
we do not use it below either and it has to be symmetric
On 2012/10/15 21:54:11, Ben Goodger (Google) wrote:
> && OS CHROMEOS?

[Ben Goodger (Google), 2012-10-15 22:19:14]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
On 2012/10/15 21:56:06, Robert Muth (chromium) wrote:
> we do not use it below either and it has to be symmetric
> On 2012/10/15 21:54:11, Ben Goodger (Google) wrote:
> > && OS CHROMEOS?
> 

Does this affect Clank etc too then?

[robertm, 2012-10-15 22:25:48]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
yes but clank does not have native client support at this point.
(also we will revert this for M24 later this week, this CL is just going into
trunk so we can request a merge into M23)

[Ben Goodger (Google), 2012-10-15 23:01:35]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
ok so why not just make both places OS_CHROMEOS

[robertm, 2012-10-15 23:08:26]

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://chromiumcodereview.appspot.com/11155020/diff/2001/chrome/renderer/chr...
chrome/renderer/chrome_content_renderer_client.cc:583: #if defined(__arm__)
On 2012/10/15 23:01:35, Ben Goodger (Google) wrote:
> ok so why not just make both places OS_CHROMEOS

Done.

[Ben Goodger (Google), 2012-10-15 23:09:53]

lgtm

[commit-bot: I haz the power, 2012-10-15 23:11:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertm@chromium.org/11155020/5013

[commit-bot: I haz the power, 2012-10-16 01:27:04]

Change committed as 162026