Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11155017: cros: Fix crash in about:tracing (Closed)

Created:
8 years, 2 months ago by James Cook
Modified:
8 years, 2 months ago
Reviewers:
Sam Leffler, stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

cros: Fix crash in about:tracing We've seen some crashes in DebugDaemonClientImpl::OnRequestStopSystemTracing. If debugd crashes or completes I/O back to Chrome too early we could NULL out a scoped_ptr<> before the code expects it. Null check the pointer. BUG=155774 TEST=crash reports Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
chromeos/dbus/debug_daemon_client.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
Sam, PTAL. Zel says there are some crashes in debugd that are being fixed, but ...
8 years, 2 months ago (2012-10-15 19:12:18 UTC) #1
James Cook
Ping Sam?
8 years, 2 months ago (2012-10-16 16:09:41 UTC) #2
Sam Leffler
lgtm need to add a unit test for this case; can you please open an ...
8 years, 2 months ago (2012-10-16 16:15:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11155017/1
8 years, 2 months ago (2012-10-16 16:21:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 11155017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-16 16:21:25 UTC) #5
James Cook
Steven, can I get OWNERS approval for this null-check?
8 years, 2 months ago (2012-10-16 16:24:44 UTC) #6
stevenjb
lgtm
8 years, 2 months ago (2012-10-16 16:45:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11155017/1
8 years, 2 months ago (2012-10-16 16:53:22 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 19:46:21 UTC) #9
Change committed as 162217

Powered by Google App Engine
This is Rietveld 408576698