Implemented basic WebRTC Mem/CPU measurements.

Implemented basic WebRTC Mem/CPU measurements.


BUG=
NOTRY=True

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162469

[kjellander_chromium, 2012-10-15 21:19:21]

Exciting to see progress on this! Just a few minor comments.

http://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/webr...
File chrome/test/functional/webrtc_call.py (right):

http://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/webr...
chrome/test/functional/webrtc_call.py:6: import psutil
psutil sorts after os.

http://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/webr...
chrome/test/functional/webrtc_call.py:73: def testSimpleWebrtcJsep00Call(self):
Maybe it's time to drop the 00 version before it get's removed?

http://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/webr...
chrome/test/functional/webrtc_call.py:202: """Returns the Chrome renderer
process."""
Add something about what you get back and what it's generally used for?

[phoglund_chromium, 2012-10-16 21:27:08]

https://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/web...
File chrome/test/functional/webrtc_call.py (right):

https://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/web...
chrome/test/functional/webrtc_call.py:6: import psutil
On 2012/10/15 21:19:21, h.kjellander wrote:
> psutil sorts after os.

Done.

https://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/web...
chrome/test/functional/webrtc_call.py:73: def testSimpleWebrtcJsep00Call(self):
On 2012/10/15 21:19:21, h.kjellander wrote:
> Maybe it's time to drop the 00 version before it get's removed?
Not sure if I should remove it or leave it in, running with the flag. I'll look
at that in a separate patch.

https://codereview.chromium.org/11155015/diff/2001/chrome/test/functional/web...
chrome/test/functional/webrtc_call.py:202: """Returns the Chrome renderer
process."""
On 2012/10/15 21:19:21, h.kjellander wrote:
> Add something about what you get back and what it's generally used for?

Done.

[phoglund_chromium, 2012-10-16 21:28:38]

Per, can you have a look? Let's see if your LGTM is good this time :)

[phoglund_chromium, 2012-10-17 16:54:25]

Nirnimesh, looks like I need a rubberstamp here too :)

[Nirnimesh, 2012-10-17 17:57:02]

Rubberstamp LGTM.

[kjellander_chromium, 2012-10-17 18:22:13]

lgtm

[commit-bot: I haz the power, 2012-10-17 18:24:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/11155015/6001

[commit-bot: I haz the power, 2012-10-17 18:35:06]

Change committed as 162469