Issue 11154007: Fixed: on windows, fixed-size app windows would lose their shadows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11154007: Fixed: on windows, fixed-size app windows would lose their shadows. (Closed)

Created:
8 years, 2 months ago by jeremya

Modified:
8 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, ben+watch_chromium.org, tfarina, Mihai Parparita -not on Chrome, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed: on windows, fixed-size app windows would lose their shadows. Some code checked the resizability of the window and used it to key a change in window style. For app windows, we always want a very particular window style, so we check for the remove_standard_frame Widget::InitParams option and ignore the resize flag. Also, change the shell window NonClientHitTest code to not return HTTOPLEFT and friends when the window is non-resizable. R=ben@chromium.org BUG=155219 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162387

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
	M	chrome/browser/ui/views/extensions/shell_window_views.cc	View		1 chunk	+15 lines, -13 lines	0 comments	Download
	M	ui/views/widget/widget_hwnd_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/11154007/1

8 years, 2 months ago (2012-10-16 23:05:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/11154007/1

8 years, 2 months ago (2012-10-17 11:17:12 UTC) #4

Change committed as 162387

Expand Messages | Collapse Messages