Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11151032: Stop depending on wtf/MathExtras in WebTransformationMatrixTest.cpp (Closed)

Created:
8 years, 2 months ago by jamesr
Modified:
8 years, 2 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, shawnsingh
Visibility:
Public.

Description

Stop depending on wtf/MathExtras in WebTransformationMatrixTest.cpp <math.h> has all we need BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162261

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Patch Set 4 : Add _USE_MATH_DEFINES define so <math.h> defines M_PI on windows #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M webkit/compositor_bindings/WebTransformationMatrixTest.cpp View 1 2 3 7 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
8 years, 2 months ago (2012-10-16 01:17:19 UTC) #1
enne (OOO)
lgtm
8 years, 2 months ago (2012-10-16 01:23:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11151032/1
8 years, 2 months ago (2012-10-16 01:25:49 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-16 01:48:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11151032/4002
8 years, 2 months ago (2012-10-16 01:51:42 UTC) #5
commit-bot: I haz the power
Failed to apply patch for webkit/compositor_bindings/WebTransformationMatrixTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-16 01:51:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11151032/5003
8 years, 2 months ago (2012-10-16 01:58:50 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-16 02:48:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11151032/12004
8 years, 2 months ago (2012-10-16 20:18:48 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 21:49:54 UTC) #10
Change committed as 162261

Powered by Google App Engine
This is Rietveld 408576698