Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11151031: [MIPS] Update SConstruct to use new MIPS toolchain. (Closed)

Created:
8 years, 2 months ago by petarj
Modified:
8 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Update SConstruct to use new MIPS toolchain. Recent switch to a newer 4.7.2 GCC for MIPS requires changes in SConstruct. The change also includes minor change to comply with unused-but-set-variable restriction. The commit queue is not working for NaCl at the moment, so we are committing with: NOTRY=true However, we have run a try job manually, and it passed fine. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= pnacl/build.sh misc-tools Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M SConstruct View 1 chunk +8 lines, -8 lines 0 comments Download
M src/trusted/service_runtime/arch/mips/nacl_switch_to_app_mips.c View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petarj
This is a necessary follow to CL in which we changed the toolchain for MIPS: ...
8 years, 2 months ago (2012-10-16 00:11:07 UTC) #1
Mark Seaborn
LGTM. I ran into these problems today, as it happens. Thanks for fixing them before ...
8 years, 2 months ago (2012-10-16 01:11:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/11151031/1
8 years, 2 months ago (2012-10-16 09:02:05 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 2 months ago (2012-10-16 10:04:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/11151031/1
8 years, 2 months ago (2012-10-16 11:01:56 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 11:02:01 UTC) #6
Change committed as 10009

Powered by Google App Engine
This is Rietveld 408576698