Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ui/views/focus/focus_manager.cc

Issue 11150035: Remove obsolete code that handles menu key release for chromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/focus/focus_manager.h ('k') | ui/views/widget/desktop_root_window_host_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/focus/focus_manager.cc
diff --git a/ui/views/focus/focus_manager.cc b/ui/views/focus/focus_manager.cc
index 7594754556bf525b4a8c9f9bdd07b067984b4d56..3ead1ada7869ba0bae85d0b9f6fd27ffaf2a4232 100644
--- a/ui/views/focus/focus_manager.cc
+++ b/ui/views/focus/focus_manager.cc
@@ -30,9 +30,6 @@ FocusManager::FocusManager(Widget* widget, FocusManagerDelegate* delegate)
focused_view_(NULL),
accelerator_manager_(new ui::AcceleratorManager),
focus_change_reason_(kReasonDirectFocusChange),
-#if defined(USE_X11)
- should_handle_menu_key_release_(false),
-#endif
is_changing_focus_(false) {
DCHECK(widget_);
stored_focused_view_storage_id_ =
@@ -45,39 +42,8 @@ FocusManager::~FocusManager() {
bool FocusManager::OnKeyEvent(const ui::KeyEvent& event) {
const int key_code = event.key_code();
-#if defined(USE_X11)
- // TODO(ben): beng believes that this should be done in
- // RootWindowHosLinux for aura/linux.
-
- // Always reset |should_handle_menu_key_release_| unless we are handling a
- // VKEY_MENU key release event. It ensures that VKEY_MENU accelerator can only
- // be activated when handling a VKEY_MENU key release event which is preceded
- // by an un-handled VKEY_MENU key press event.
- if (key_code != ui::VKEY_MENU || event.type() != ui::ET_KEY_RELEASED)
- should_handle_menu_key_release_ = false;
-
- if (event.type() == ui::ET_KEY_PRESSED) {
- // VKEY_MENU is triggered by key release event.
- // FocusManager::OnKeyEvent() returns false when the key has been consumed.
- if ((key_code == ui::VKEY_MENU) &&
- (event.flags() & ~ui::EF_ALT_DOWN) == 0) {
- should_handle_menu_key_release_ = true;
- return false;
- }
- // Pass through to the rest of OnKeyEvent.
- } else if (key_code == ui::VKEY_MENU && should_handle_menu_key_release_ &&
- (event.flags() & ~ui::EF_ALT_DOWN) == 0) {
- // Trigger VKEY_MENU when only this key is pressed and released, and both
- // press and release events are not handled by others.
- ui::Accelerator accelerator(ui::VKEY_MENU, ui::EF_NONE);
- return ProcessAccelerator(accelerator);
- } else if (event.type() != ui::ET_KEY_RELEASED) {
- return false;
- }
-#else
if (event.type() != ui::ET_KEY_PRESSED && event.type() != ui::ET_KEY_RELEASED)
return false;
-#endif
if (shortcut_handling_suspended())
return true;
@@ -308,10 +274,6 @@ void FocusManager::ClearFocus() {
}
void FocusManager::StoreFocusedView() {
-#if defined(USE_X11)
- // Forget menu key state when the window lost focus.
- should_handle_menu_key_release_ = false;
-#endif
ViewStorage* view_storage = ViewStorage::GetInstance();
if (!view_storage) {
// This should never happen but bug 981648 seems to indicate it could.
@@ -345,9 +307,6 @@ void FocusManager::StoreFocusedView() {
}
void FocusManager::RestoreFocusedView() {
-#if defined(USE_X11)
- DCHECK(!should_handle_menu_key_release_);
-#endif
ViewStorage* view_storage = ViewStorage::GetInstance();
if (!view_storage) {
// This should never happen but bug 981648 seems to indicate it could.
@@ -444,17 +403,6 @@ bool FocusManager::ProcessAccelerator(const ui::Accelerator& accelerator) {
return false;
}
-void FocusManager::MaybeResetMenuKeyState(const ui::KeyEvent& key) {
-#if defined(USE_X11)
- // Always reset |should_handle_menu_key_release_| unless we are handling a
- // VKEY_MENU key release event. It ensures that VKEY_MENU accelerator can only
- // be activated when handling a VKEY_MENU key release event which is preceded
- // by an unhandled VKEY_MENU key press event. See also HandleKeyboardEvent().
- if (key.key_code() != ui::VKEY_MENU || key.type() != ui::ET_KEY_RELEASED)
- should_handle_menu_key_release_ = false;
-#endif
-}
-
ui::AcceleratorTarget* FocusManager::GetCurrentTargetForAccelerator(
const ui::Accelerator& accelerator) const {
ui::AcceleratorTarget* target =
« no previous file with comments | « ui/views/focus/focus_manager.h ('k') | ui/views/widget/desktop_root_window_host_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698