Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: content/browser/download/download_item_impl.h

Issue 11150027: Handle the case where IAttachmentExecute::Save() deletes a downloaded file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + Address comments + Update strings Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index c49677c9738905fd173b7ec7fcc83ba593fb15e6..e0866550616cb404b2cc5e9f7f11cf7657629278 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -208,10 +208,10 @@ class CONTENT_EXPORT DownloadItemImpl
// TODO(rdsmith): Put in state variable for file name determination.
IN_PROGRESS_INTERNAL,
- // Between commit point (dispatch of download file release) and
- // completed. Embedder may be opening the file in this state.
- // Note that the DownloadItem may be deleted (by shutdown) in this
- // state.
+ // Between commit point (dispatch of download file release) and completed.
+ // Embedder may be opening the file in this state. Note that the
+ // DownloadItem may be deleted (by shutdown) or interrupted (e.g. due to a
+ // failure during AnnotateWithSourceInformation()) in this state.
COMPLETING_INTERNAL,
// After embedder has had a chance to auto-open. User may now open
@@ -279,7 +279,9 @@ class CONTENT_EXPORT DownloadItemImpl
void ReleaseDownloadFile();
- void OnDownloadFileReleased();
+ // TODO(rdsmith,asanka): Move the AnnotateWithSourceInformation() call to the
+ // final rename and eliminate the interrupt reason callback.
+ void OnDownloadFileReleased(DownloadInterruptReason reason);
// Called when the entire download operation (including renaming etc)
// is completed.
« no previous file with comments | « content/browser/download/download_interrupt_reasons_impl.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698