Configure IE 10 for the various Chrome Frame tests.

Configure IE 10 for the various Chrome Frame tests.

BUG=155501
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162416

[robertshield, 2012-10-14 01:30:34]

lgtm, coupla nits

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
File chrome_frame/test/ie_configurator.cc (right):

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
chrome_frame/test/ie_configurator.cc:362:
ModernIEConfigurator::RunOnceValueNames
how do you feel about sticking this in a constructor for RunOnceValueNames?

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
chrome_frame/test/ie_configurator.cc:453: // Suppress the "Set up Internet
Explorer 9" dialog.
nit: no 9

[grt (UTC plus 2), 2012-10-15 14:16:16]

Thanks.  Please take another look.

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
File chrome_frame/test/ie_configurator.cc (right):

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
chrome_frame/test/ie_configurator.cc:362:
ModernIEConfigurator::RunOnceValueNames
On 2012/10/14 01:30:34, robertshield wrote:
> how do you feel about sticking this in a constructor for RunOnceValueNames?

Not so great.  The names struct is a super-lightweight aggregate that I don't
think needs version-checking logic.  I've rejiggered things a little bit to get
rid of constructing RunOnceValueNames instances dynamically (the compiler/linker
can put them in .rdata).  Please let me know what you think.

https://codereview.chromium.org/11149009/diff/1/chrome_frame/test/ie_configur...
chrome_frame/test/ie_configurator.cc:453: // Suppress the "Set up Internet
Explorer 9" dialog.
On 2012/10/14 01:30:34, robertshield wrote:
> nit: no 9

Done.

[robertshield, 2012-10-17 13:44:59]

SLGTM

[commit-bot: I haz the power, 2012-10-17 13:56:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/11149009/6001

[commit-bot: I haz the power, 2012-10-17 15:49:49]

Change committed as 162416