Restore previous behavior of GetSha1ForSvnRev, so unit tests pass.

Restore previous behavior of GetSha1ForSvnRev, so unit tests pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161909

[M-A Ruel, 2012-10-15 18:34:05]

I would have preferred a test, but instead I will leave you fix it if it breaks.
:)

lgtm

https://codereview.chromium.org/11148019/diff/1/scm.py
File scm.py (right):

https://codereview.chromium.org/11148019/diff/1/scm.py#newcode438
scm.py:438: 
Just one vertical line for non-file level symbol

[szager1, 2012-10-15 18:37:52]

On 2012/10/15 18:34:05, Marc-Antoine Ruel wrote:
> I would have preferred a test, but instead I will leave you fix it if it
breaks.
> :)

Yeah, unfortunately, updating the test mock to replicate the new git repository
layout would be onerously hard and probably break a bunch of other tests.  So
I'm taking the easy way out.

[szager1, 2012-10-15 18:37:58]

https://codereview.chromium.org/11148019/diff/1/scm.py
File scm.py (right):

https://codereview.chromium.org/11148019/diff/1/scm.py#newcode438
scm.py:438: 
On 2012/10/15 18:34:05, Marc-Antoine Ruel wrote:
> Just one vertical line for non-file level symbol

Done.

[commit-bot: I haz the power, 2012-10-15 18:38:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/11148019/4001

[commit-bot: I haz the power, 2012-10-15 18:41:17]

Presubmit check for 11148019-4001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/scm_unittest.py failed!
Command tests/scm_unittest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
..['GetBlessedSha1ForSvnRev']
F..............
======================================================================
FAIL: testMembersChanged (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/pymox/mox.py",
line 1618, in new_method
    func(self, *args, **kwargs)
  File "tests/scm_unittest.py", line 99, in testMembersChanged
    self.compareMembers(scm.GIT, members)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 78, in compareMembers
    self.assertEqual(actual_members, expected_members)
AssertionError: ['AssertVersion', 'Capture', 'CaptureStatus',
'FetchUpstreamTuple', 'GenerateDiff', 'GetBlessedSha1ForSvnRev', 'GetBranch',
'GetBranchRef', 'GetCheckoutRoot', 'GetDifferentFiles', 'GetEmail',
'GetGitSvnHeadRev', 'GetPatchName', 'GetSVNBranch', 'GetSha1ForSvnRev',
'GetUpstreamBranch', 'IsGitSvn', 'IsValidRevision', 'MatchSvnGlob',
'ParseGitSvnSha1', 'ShortBranchName', 'current_version'] != ['AssertVersion',
'Capture', 'CaptureStatus', 'FetchUpstreamTuple', 'GenerateDiff', 'GetBranch',
'GetBranchRef', 'GetCheckoutRoot', 'GetDifferentFiles', 'GetEmail',
'GetGitSvnHeadRev', 'GetPatchName', 'GetSVNBranch', 'GetSha1ForSvnRev',
'GetUpstreamBranch', 'IsGitSvn', 'IsValidRevision', 'MatchSvnGlob',
'ParseGitSvnSha1', 'ShortBranchName', 'current_version']

----------------------------------------------------------------------
Ran 17 tests in 18.123s

FAILED (failures=1)


Presubmit checks took 163.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-10-15 18:47:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szager@chromium.org/11148019/7001

[commit-bot: I haz the power, 2012-10-15 18:50:43]

Change committed as 161909