Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: build/android/pylib/base_test_runner.py

Issue 11148018: Upstream the android python scripts changes that enable the new Forwarder2 to be used in our test f… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all_android.gyp ('k') | build/android/pylib/forwarder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base_test_runner.py
diff --git a/build/android/pylib/base_test_runner.py b/build/android/pylib/base_test_runner.py
index a69d0244b603a58e2472cbb47171fbf65f1fa23d..619bc6edf060ce8e396b741dc631ba073472d394 100644
--- a/build/android/pylib/base_test_runner.py
+++ b/build/android/pylib/base_test_runner.py
@@ -127,6 +127,7 @@ class BaseTestRunner(object):
else:
logging.critical('Failed to start http server')
self.StartForwarderForHttpServer()
+ return (self._forwarder_device_port, self._http_server.port)
def StartForwarder(self, port_pairs):
"""Starts TCP traffic forwarding for the given |port_pairs|.
@@ -134,10 +135,6 @@ class BaseTestRunner(object):
Args:
host_port_pairs: A list of (device_port, local_port) tuples to forward.
"""
- # Sometimes the forwarder device port may be already used. We have to kill
- # all forwarder processes to ensure that the forwarder can be started since
- # currently we can not associate the specified port to related pid.
- self.adb.KillAll('forwarder')
if self._forwarder:
self._forwarder.Close()
self._forwarder = Forwarder(
@@ -168,7 +165,7 @@ class BaseTestRunner(object):
if self._forwarder or self._spawner_forwarder:
# Kill all forwarders on the device and then kill the process on the host
# (if it exists)
- self.adb.KillAll('forwarder')
+ self.adb.KillAll('device_forwarder')
if self._forwarder:
self._forwarder.Close()
if self._spawner_forwarder:
« no previous file with comments | « build/all_android.gyp ('k') | build/android/pylib/forwarder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698